Split identifier registry#754
Open
wvpm wants to merge 1 commit into
Open
Conversation
wvpm
force-pushed
the
split_identifier_registry
branch
from
456a4d7 to
7529de3
Compare
wvpm
force-pushed
the
split_identifier_registry
branch
3 times, most recently
from
29b35bb to
4d24716
Compare
wvpm
force-pushed
the
forward_nodetools_types
branch
3 times, most recently
from
271eb78 to
3c60608
Compare
wvpm
force-pushed
the
split_identifier_registry
branch
2 times, most recently
from
3082dc0 to
9bb1f09
Compare
wvpm
force-pushed
the
forward_nodetools_types
branch
2 times, most recently
from
0e8f274 to
d130288
Compare
wvpm
force-pushed
the
split_identifier_registry
branch
5 times, most recently
from
0a30ebe to
a820285
Compare
wvpm
force-pushed
the
forward_nodetools_types
branch
4 times, most recently
from
46bcaf6 to
4f86b94
Compare
wvpm
force-pushed
the
split_identifier_registry
branch
2 times, most recently
from
52c7c2c to
e1fe174
Compare
wvpm
force-pushed
the
split_identifier_registry
branch
from
e1fe174 to
8074731
Compare
wvpm
force-pushed
the
split_identifier_registry
branch
from
8074731 to
474c24e
Compare
wvpm
force-pushed
the
prepare_for_identifierregsitry_refactor
branch
from
3ab13fd to
d0d8104
Compare
wvpm
force-pushed
the
split_identifier_registry
branch
from
474c24e to
deb38e1
Compare
wvpm
force-pushed
the
prepare_for_identifierregsitry_refactor
branch
2 times, most recently
from
7ed3847 to
798a19a
Compare
wvpm
force-pushed
the
split_identifier_registry
branch
from
deb38e1 to
c586288
Compare
Catylist0
approved these changes
May 25, 2026
Catylist0
left a comment
Catylist0
left a comment
There was a problem hiding this comment.
Looks fine, definitely agree with splitting out the headers and I don't see any issues with the implementation
wvpm
force-pushed
the
split_identifier_registry
branch
from
c586288 to
3ffae2b
Compare
wvpm
force-pushed
the
split_identifier_registry
branch
from
3ffae2b to
e66998d
Compare
wvpm
force-pushed
the
split_identifier_registry
branch
from
e66998d to
6bac070
Compare
wvpm
force-pushed
the
split_identifier_registry
branch
3 times, most recently
from
275a00c to
b5021b0
Compare
wvpm
force-pushed
the
split_identifier_registry
branch
5 times, most recently
from
a463510 to
d67f464
Compare
wvpm
force-pushed
the
split_identifier_registry
branch
from
d67f464 to
1605d1e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on top of #758
Goal: reduce headers spreading everywhere, specifically NodeTools.hpp included in IdentifierRegistry.hpp.
Plan: replace IdentifierRegistry.hpp with minimal headers for storage and free functions for searching and modifying.